Skip to content

Only request credentials for the appropriate providers #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Only request credentials for the appropriate providers #1120

merged 1 commit into from
Jan 23, 2018

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jan 23, 2018 •
edited
Loading

Related to #1118

@samtstern
Only request credentials for the appropriate providers
118c1b5 
Change-Id: Ie692b8e45fc4d3f24877ea32cb18306c2c8b9392
@samtstern samtstern requested a review from SUPERCILEX January 23, 2018 18:05
@samtstern samtstern added this to the 3.2.1 milestone Jan 23, 2018
SUPERCILEX
SUPERCILEX approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@SUPERCILEX SUPERCILEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samtstern This doesn't fix #1118, but LGTM for the possible bugs it does fix 👍.

@samtstern samtstern merged commit 7e3d057 into version-3.2.1-dev Jan 23, 2018
@samtstern samtstern deleted the issue-1118 branch January 23, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SUPERCILEX SUPERCILEX SUPERCILEX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@samtstern @SUPERCILEX